[jimple] Remove jsp add html and json #4528
Conversation
I would not consider jsp to be config files but code. Also added json and HTML files. The latter usually also does not contain configurations but i would expect it there (currently).
DavidBakerEffendi
left a comment
DavidBakerEffendi
left a comment
There was a problem hiding this comment.
You may need to also add entries for this under io.joern.x2cpg.passes.frontend.JavaConfigFileCreationPass to have it working e2e
|
Besides the weirdly formatted Java code, JSP will usually contain HTML. At qwiet, we don't use jimple2cpg, but for javasrc2cpg and java2cpg we look at the HTML contained in |
For me it is ok to keep (or add?) the JSP to the config file node because we might loose (important) information otherwise. However, the point of JSP having HTML content is opening up a path where we potentially end up adding everything except |
DavidBakerEffendi
left a comment
DavidBakerEffendi
left a comment
There was a problem hiding this comment.
For Jimple this choice is fine I think, but remember to add .html to the filters in io.joern.x2cpg.passes.frontend.JavaConfigFileCreationPass otherwise this won't be picked up. Alternatively, one can add a config test similar to what is in Java.
I would not consider jsp to be config files but code. Also added json and HTML files. The latter usually also does not contain configurations but i would expect it there (currently).